RFR (S): 8191888: Refactor ClassLoaderData::remove_handle to use the Access API
erik.osterlund at oracle.com
Tue Nov 28 15:32:25 UTC 2017
Thanks for the review.
On 2017-11-28 16:07, Per Liden wrote:
> Looks good!
> On 2017-11-27 10:06, Erik Österlund wrote:
>> The ClassLoaderData::remove_handle() member function currently uses
>> explicit G1 SATB barriers to remove an oop from the root set, as these
>> handles are not necessarily walked by the GC in a safepoint. Therefore
>> G1 needs pre-write barriers.
>> This should now be modeled as a
>> RootAccess<IN_CONCURRENT_ROOT>::oop_store instead. This maps to
>> performing a pre-write SATB barrier with G1, but other GCs are free to
>> do other things as necessary.
More information about the hotspot-gc-dev