RFR(T): 8230332: G1DirtyCardQueueSet _notify_when_complete is always true
stefan.johansson at oracle.com
Thu Aug 29 07:10:00 UTC 2019
On 2019-08-29 03:05, Kim Barrett wrote:
> Please review this trivial cleanup of G1DirtyCardQueueSet. With the
> separation of G1RedirtyCardsQueueSet from G1DirtyCardQueueSet, the
> latter is now a singleton class. As a result, the
> _notify_when_complete member (used to control whether adding completed
> buffers should notify the completed buffer monitor) is always true.
> This change removes that member and changes the conditional
> notifications to be unconditional. Also cleaned up some locker usage
> for _cbl_mon when notification is needed, and changed to consistently
> use notify_all() (there's no good reason to use notify(), and
> definitely no good reason to use a mix of the two here).
Looks good, nice cleanup.
> Local (linux-x64) hotspot:tier1
More information about the hotspot-gc-dev