RFR (M): 8235860: Obsolete the UseParallelOldGC option

Thomas Schatzl thomas.schatzl at oracle.com
Wed Dec 18 09:52:30 UTC 2019


Hi,

On 18.12.19 06:44, Kim Barrett wrote:
>> On Dec 17, 2019, at 10:51 AM, Thomas Schatzl <thomas.schatzl at oracle.com> wrote:
>>
>> Hi all,
>>
>>   can I get reviews for this change that implements obsoletion of the UseParallelOldGC option, i.e. removal of the Parallel GC Serial Old collector?
>>
>> ((I am counting this as "M" because it's 99% removal of code)
>>
>> CR:
>> https://bugs.openjdk.java.net/browse/JDK-8235860
>> Webrev:
>> http://cr.openjdk.java.net/~tschatzl/8235860/webrev/
>> Testing:
>> hs-tier1-5 almost done
>>
>> Thanks,
>>   Thomas
> 
> Looks good.  One very minor issue and some pre-existing issues with
> the block comment before SplitInfo.  That block comment should be
> dealt with separately from this change.
> 
> ------------------------------------------------------------------------------
> src/hotspot/share/gc/parallel/parallelArguments.cpp
>    47   assert(UseParallelGC, "Error");
>    48   FLAG_SET_DEFAULT(UseParallelGC, true);
> 
> I think line 48 was to account for the possibility that we got here
> via +UseParallelOldGC.  It's redundant now.
> 
> ------------------------------------------------------------------------------
> src/hotspot/share/gc/parallel/psParallelCompact.hpp
>   886 // ...  The permanent generation is
> 
> Pre-existing lingering comments about permgen.

Fixed in
http://cr.openjdk.java.net/~tschatzl/8235860/webrev.0_to_1 (diff)
http://cr.openjdk.java.net/~tschatzl/8235860/webrev.1 (full)

> 
> ------------------------------------------------------------------------------
> src/hotspot/share/gc/parallel/psParallelCompact.hpp
> 
> Pre-existing: It seems like the big block comment before SplitInfo
> should have received some updates as part of the recent shadow-region
> patch, but it wasn't touched.
> 
> ------------------------------------------------------------------------------
> 

I am filing a CR for that.

Thanks,
   Thomas


More information about the hotspot-gc-dev mailing list