RFR: 8212630: jtreg/gc/logging/TestMetaSpaceLog.java failed with Agent timed out

Leonid Mesnik leonid.mesnik at oracle.com
Mon Jun 3 17:28:34 UTC 2019


On 5/31/19 5:37 PM, Kim Barrett wrote:
>> On May 31, 2019, at 1:04 AM, Leonid Mesnik <leonid.mesnik at oracle.com> wrote:
>>> On May 30, 2019, at 5:04 PM, Kim Barrett <kim.barrett at oracle.com> wrote:
>>> Note that I tested it with an additional @run line for Shenandoah
>>> (with it configured out as usual for our builds, so not supported),
>>> and that worked fine, giving the expected "passed because skipped"
>>> result.
>> As I understand in this case test is not going to execute any @run after skipped one. So if anyone decide to add Shenandoah testing as first @run then test is going to test nothing and always pass as skipped in our testing.
> That's not true.  (If it were, I'd call it a bug.)
>> Please note that this test is always executed with all GCs specified even if specific GC is set using jtreg options. It doesn't harm for single test but increase wasting time if many tests use this approach.
>> BTW If test is not GC specific then it might just pick GC from jtreg command-line. It might be no sense to run it with all GCs explicitly each time.
> I think what you are suggesting is this:
> http://cr.openjdk.java.net/~kbarrett/8212630/open.01
> and depend on running the test with various different GCs selected by
> the outer test driver (like mach5) to provide coverage.  I think for
> the current mach5 CI configuration, that would (currently) mean, for this
> test, default (G1) in tier1 and explicit G1 and others in tier2 or tier3.
> I guess that's okay.

Such fix looks good for me if all unsupported vm configs are excluded by 
requires. The good thing that test now accepts any additional VM flags 
and not different GC only!

Thank for fixing.



More information about the hotspot-gc-dev mailing list