RFR: 8225716: G1 GC: Undefined behaviour in G1BlockOffsetTablePart::block_at_or_preceding

Andrew Haley aph at redhat.com
Fri Jun 14 15:23:52 UTC 2019

On 6/14/19 1:06 PM, Thomas Schatzl wrote:

> Btw, please push the final fix into the jdk/jdk13 repos (I assume we
> will manage reviewing this in time ;)). In any case this is serious
> enough to get it into the product asap.

Here, with all comments in this thread take into account:


One thing which gave me pause was the need to cast away const when
calling memset_with_concurrent_readers(). I don't think it's actually
wrong, given that memset_with_concurrent_readers() has the
specification we need: we don't need strict volatile behaviour in the
sense of ordering. We just need to be sure that there are no
intermediate values other than what we ask for.

Andrew Haley
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671

More information about the hotspot-gc-dev mailing list