RFR(S)[13]: AArch64: float point register corruption in ZBarrierSetAssembler::load_at

Andrew Haley aph at redhat.com
Sat Jun 22 08:01:46 UTC 2019

On 6/21/19 5:02 PM, Stuart Monteith wrote:
>    I'm trying passing r19 instead of rscratch1 to __ load_mirror and
> also checking that rscratch1,2 aren't passed to load_at. That would
> free up rscratch1 and 2 to be used, and not saved, in load_at.

Yes. Better.

> The tmp register is more often than not set to rscratch2 or noreg,
> so it isn't a terribly useful parameter.

Huh? It makes no sense to pass noreg as a tmp. A callee has a right
to assume that a reg passed as tmp can be used.

Andrew Haley  (he/him)
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671

More information about the hotspot-gc-dev mailing list