RFR (XXL): 8213108: Improve work distribution during remembered set scan

Leo Korinth leo.korinth at oracle.com
Mon Jun 24 17:55:57 UTC 2019


Sorry for taking so very long time to review. In g1RemSet.cpp:

* uint const num_chunks = (uint)align_up((size_t)num_regions << 
HeapRegion::LogCardsPerRegion, G1ClearCardTableTask::chunk_size()) / 

make sure the (uint) cast is done after the division (so not to cast 
away bits).

* initialize _scan_chunks_shift in initializer list to silence eclipse 

* in ::memset(_region_scan_chunks, false, _max_regions * 
_scan_chunks_per_region); please multiply last argument with 

Otherwise it looks very good to my untrained eyes. I gave you a few 
extra ideas off list, you may add some of them if you like.


On 17/06/2019 21:09, Kim Barrett wrote:
>> On Jun 17, 2019, at 8:23 AM, Thomas Schatzl <thomas.schatzl at oracle.com> wrote:
>> New webrev:
>> http://cr.openjdk.java.net/~tschatzl/8213108/webrev.1_to_2/ (diff)
>> http://cr.openjdk.java.net/~tschatzl/8213108/webrev.2/ (full)
>> Testing: hs-tier1-3
>> Thanks,
>>   Thomas
> Looks good.

More information about the hotspot-gc-dev mailing list