RFR: 8224764 - Create jtreg test for JDK-8222252
thomas.schatzl at oracle.com
Tue Jun 25 12:33:34 UTC 2019
On Mon, 2019-06-24 at 13:19 -0400, Bob Vandette wrote:
> Ping …
sorry, I overlooked that one...
> > On Jun 18, 2019, at 8:28 AM, Bob Vandette <bob.vandette at oracle.com>
> > wrote:
> > Please review this new test that verifies the updated behavior for
> > -XX:MaxRAMPercentage and -XX:MaxRAM
> > as documented in these two bugs:
> > https://bugs.openjdk.java.net/browse/JDK-8213175 - Java ergonomics
> > limits heap to 32GB to allow compressed oops
> > https://bugs.openjdk.java.net/browse/JDK-8222252 - Java ergonomics
> > limits heap to 128GB with disabled compressed oops
> > BUG:
> > https://bugs.openjdk.java.net/browse/JDK-8224764
> > WEBREV:
> > http://cr.openjdk.java.net/~bobv/8224764/webrev.00
> > The test attempts to set MaxRAM 1G below and above the Maximum Heap
> > size allowed by CompressedOops and verifies that compressed oops is
> > disabled when the requested heap size is above the limit. It also
> > verifies that if UseCompressedOops is specified, it will limit the
> > heap size.
- I would exclude the test for non-64 bit VMs in the header instead at
runtime. This saves unnecessary executions.
I.e. add a "@requires vm.bits == "64" in the header and remove the
corresponding code in the main method.
- line 71 seems to be some debug code to remove
- line 125 seems to be some additional code that fixes(?) some issue
you had determining the max heap for compressed oops. If so, I would
prefer to put that in
More information about the hotspot-gc-dev