[aarch64-port-dev ] RFR 8233401: Shenandoah: Refactor/cleanup Shenandoah load barrier code
aph at redhat.com
Tue Nov 5 16:26:19 UTC 2019
On 11/5/19 12:33 PM, Zhengyu Gu wrote:
> On 11/5/19 3:52 AM, Andrew Haley wrote:
>> On 11/4/19 6:23 PM, Zhengyu Gu wrote:
>>>> They are still needed for calling super class's load_at(). Even though,
>>>> they are not used there neither.
>> Aha! Sorry, I missed that.
>>> Or I should say, they are not used there right now, but may be used in
>>> future ...
>> So add them in the future, surely. All you're doing by passing unused
>> args is confusing the reader. It definitely succeeded with me...
> Sorry, I should just remove 'unused' comments. Okay with you?
Andrew Haley (he/him)
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671
More information about the hotspot-gc-dev