[aarch64-port-dev ] RFR 8233401: Shenandoah: Refactor/cleanup Shenandoah load barrier code

Aleksey Shipilev shade at redhat.com
Wed Nov 6 13:45:27 UTC 2019

On 11/6/19 1:18 PM, Zhengyu Gu wrote:
> Updated: http://cr.openjdk.java.net/~zgu/JDK-8233401/webrev.02/index.html

Minor nits:

*) shenandoahBarrierSetAssembler_aarch64.cpp: excess space between parentheses:

 368   if (!is_reference_type(type) ) {

*) shenandoahBarrierSetC1.cpp: so, native oop loads used to call to
ShenandoahRuntime::load_reference_barrier_native before this refactoring? That would mean it is
enabled even when "passive" is enabled (which implies -ShenandoahLRB)? Current change looks fine,
but we need to recognize this is the behavioral change. Please link the issue where that regression
was introduced.

Otherwise looks fine to me, let Roman ack it too.


More information about the hotspot-gc-dev mailing list