RFR (M): 8233306: Sort members in G1's HeapRegion after removal of Space dependency
thomas.schatzl at oracle.com
Thu Nov 14 12:42:37 UTC 2019
On 13.11.19 10:17, Stefan Johansson wrote:
> Hi Thomas,
> On 2019-10-31 14:47, Thomas Schatzl wrote:
>> Hi all,
>> after the change to HeapRegion in JDK-8233306 the declaration fo the
>> HeapRegion class is a bit messed up (merging G1ContiguousSpace, adding
>> a few members needed from ContiguousSpace).
>> This change tries to fix this as much as possible by shuffling around
>> stuff (i.e. grouping allocation related methods, evacuation related
>> methods, some helper pointers in HeapRegion, etc).
>> Depends on JDK-8189737 also out for review.
> Looks good,
thanks for your review.
Fyi, there has been one merge issue with latest NUMA changes: in
heapRegion.cpp, in the initializer list of HeapRegion::HeapRegion, NUMA
added a _node_index member at the end. This caused the merge logic to
bail out because the context of the source hunk and the current code did
not exactly match.
I updated the webrev.
More information about the hotspot-gc-dev