RFR (S): 8234208: Logging reports zero total refined cards under "Before GC RS summary"

Kim Barrett kim.barrett at oracle.com
Fri Nov 15 02:22:50 UTC 2019

> On Nov 14, 2019, at 9:11 PM, Man Cao <manc at google.com> wrote:
> Hi all,
> Can I have reviews for this fix for GC logging in G1RemSetSummary?
> Webrev: https://cr.openjdk.java.net/~manc/8234208/webrev.00/
> Bug: https://bugs.openjdk.java.net/browse/JDK-8234208
> This fix makes G1RemSetSummary independent of G1Policy, which in my opinion
> is cleaner than reordering the
> callsites of policy()->record_collection_pause_start() and
> rem_set()->print_periodic_summary_info(). The cost of summing up the total
> number of refined cards should be negligible.
> I also removed a null check for _rs_threads_vtimes, which is unnecessary
> after JDK-8183226.
> -Man

  53   _total_mutator_refined_cards = G1BarrierSet::dirty_card_queue_set().total_mutator_refined_cards();
Should be #including g1BarrierSet.hpp for this.


Looks good, other than that.  I don't need another webrev for the
additional #include.

More information about the hotspot-gc-dev mailing list