RFR: 8141637: Parallelize single threaded heap region iteration during Pre Evacuate Collection Set

Thomas Schatzl thomas.schatzl at oracle.com
Mon Nov 18 17:59:16 UTC 2019

Hi Stefan,

On 18.11.19 17:35, Stefan Johansson wrote:
> Hi Thomas,
> Thanks for reviewing.
> On 2019-11-15 11:35, Thomas Schatzl wrote:
>> Hi,
>> On 15.11.19 10:38, Stefan Johansson wrote:
>>> Hi,
>>> Please review this fix to parallelize parts of the G1 young gc 
>>> preparation.
>>> Issue: https://bugs.openjdk.java.net/browse/JDK-8141637
>>> Webrev: http://cr.openjdk.java.net/~sjohanss/8141637/00/

> Updated webrevs:
> Full: http://cr.openjdk.java.net/~sjohanss/8141637/01/
> Inc: http://cr.openjdk.java.net/~sjohanss/8141637/00-01/

   looks good.

It would be nice to rename the G1RemSet::prepare_for_scan_heap_roots() 
method to G1RemSet::exclude_from_scan() as we discussed internally in 
this change too. It does not seem to warrant an extra CR, unless you 
have more planned.

I would not need a re-review for that rename, but you need to wait for 
another reviewer anyway....


More information about the hotspot-gc-dev mailing list