RFR (S): 8234179: Move HeapRegion::_recorded_rs_length/_predicted_elapsed_time_ms into G1CollectionSet
leo.korinth at oracle.com
Mon Nov 25 14:17:31 UTC 2019
On 25/11/2019 14:34, Thomas Schatzl wrote:
> Hi Leo,
> On 22.11.19 17:37, Leo Korinth wrote:
>> On 22/11/2019 10:57, Thomas Schatzl wrote:
>>> Hi all,
>>> can I have reviews for this change that moves two members
>>> (_recorded_rs_length/_predicted_elapsed_time_ms) of HeapRegion into
>>> G1CollectionSet that is the only user of these members?
>>> This also allows more efficient allocation of this information in the
>>> future, as these are only needed for eden regions.
>> Looks good in general, the array _inc_collection_set_stats should be
>> initialized though.
> Good idea.
> Now initializes the array with known bad values so that the asserts will
> catch any use-before-init situations
Thanks Thomas, it still looks good!
> Passes hs-tier1-5
More information about the hotspot-gc-dev