RFR: 8230404: Refactor logged card refinement support in G1DirtyCardQueueSet

Kim Barrett kim.barrett at oracle.com
Thu Sep 5 19:14:28 UTC 2019

> On Sep 5, 2019, at 9:31 AM, Stefan Johansson <stefan.johansson at oracle.com> wrote:
> Hi Kim,
> On 2019-08-31 08:09, Kim Barrett wrote:
>> […]
>> CR:
>> https://bugs.openjdk.java.net/browse/JDK-8230404
>> Webrev:
>> http://cr.openjdk.java.net/~kbarrett/8230404/open.00/
> The change looks good, indeed easier to follow the code now.


> Had one thought around G1CardTableEntryClosure::apply_to_buffer, and if that should be in a separate closure that wraps the G1CardTableEntryClosure where needed. Not a big thing and if you prefer it to keep the code as is I don't mind.

I took a look at this idea.  It didn't seem to provide any benefit; it
increased source code size and required additional indirections.  So
I'm leaving it as is.

> Thanks,
> Stefan
>> Testing:
>> mach5 tier1-5

More information about the hotspot-gc-dev mailing list