RFR: 8230796: Remove BarrierSet::oop_equals_operator_allowed()

Aleksey Shipilev shade at redhat.com
Tue Sep 10 10:59:35 UTC 2019

On 9/10/19 12:57 PM, Per Liden wrote:
> On 9/10/19 12:50 PM, Aleksey Shipilev wrote:
>> On 9/10/19 12:47 PM, Per Liden wrote:
>>> BarrierSet::oop_equals_operator_allowed() is no longer specialized by any barrier set and can be
>>> removed.
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8230796
>>> Webrev: http://cr.openjdk.java.net/~pliden/8230796/webrev.0
>> Yes, the only use was Shenandoah, and it is not need it anymore.
>> Looks good.
> Thanks for reviewing.
> Btw, as a follow up, I'm looking at removing oopDesc::equals()/equals_raw() and the related Access
> infrastructure, which should also be the same for all GCs now.

I'd talk with Valhalla folks first. IIRC, early Vahalla prototypes involved overloading acmp for
properly handling value obj comparisons. oopDesc::equals(_raw) might come handy there.


More information about the hotspot-gc-dev mailing list