RFR(M): 8248401: Refactor/unify RMI gc support functionality

Kim Barrett kim.barrett at oracle.com
Fri Aug 7 11:40:54 UTC 2020


> On Aug 7, 2020, at 7:36 AM, Kim Barrett <kim.barrett at oracle.com> wrote:
> 
>> On Aug 4, 2020, at 6:02 AM, Thomas Schatzl <thomas.schatzl at oracle.com> wrote:
>> New webrevs:
>> http://cr.openjdk.java.net/~tschatzl/8248401/webrev.0_to_1 (diff)
>> http://cr.openjdk.java.net/~tschatzl/8248401/webrev.1 (full)
>> 
>> Reran the test 300 times with these changes.
>> 
>> Thanks,
>> Thomas
> 
> This looks good, except for one small thing. The name
> "next_whole_heap_examined" seems odd to me. For one thing, it comes
> across as a reader rather than a writer. I think better would be
> "update_whole_heap_examined_time" or something like that.

I should have read further ahead in the email thread.

> New webrevs:
> 
> http://cr.openjdk.java.net/~tschatzl/8248401/webrev.1_to_2 (diff)
> http://cr.openjdk.java.net/~tschatzl/8248401/webrev.2 (full)

This looks even better.



More information about the hotspot-gc-dev mailing list