RFR: 8250597: G1: Improve inlining around trim_queue

stefan.johansson at oracle.com stefan.johansson at oracle.com
Thu Aug 13 11:16:34 UTC 2020


Hi Kim (and Thomas),

On 2020-08-07 09:57, Thomas Schatzl wrote:
>>>> [...]
>>>> CR:
>>>> https://bugs.openjdk.java.net/browse/JDK-8250597
>>>> Webrev:
>>>> https://cr.openjdk.java.net/~kbarrett/8250597/open.00/
>>>> https://cr.openjdk.java.net/~kbarrett/8250597/open.01/
>>>> https://cr.openjdk.java.net/~kbarrett/8250597/open.01.inc/

Looks good, nice refactoring.

> The current code is nicer, yes. Thanks for refactoring this a bit. Also 
> the changes in the allocation path where the old-gen-is-full check has 
> been moved (I did not check performance with this part of the change).

I looked at this an extra time as well. But if there would be any slight 
regression it would only be when we have an evac failure, right? So to 
me the cleaner code is more important.

Thanks,
Stefan


More information about the hotspot-gc-dev mailing list