RFR: 8245511: G1 adaptive IHOP does not account for reclamation of humongous objects by young GC
luoziyi at amazon.com
Fri Aug 14 15:53:20 UTC 2020
Thank you for your review.
May I have a second reviewer for this patch?
>On 8/14/20, 3:56 AM, Thomas Schatzl wrote:
>On 13.08.20 23:31, Luo, Ziyi wrote:
>> Hi Thomas,
>> Thanks for your comments. New revision published:
>> On 8/12/20, 2:15 AM, Thomas Schatzl wrote:
>>> Please try to provide an incremental webrev too so that we reviewers do
>>> not have to look through all changes all the time. It's easy to do (and
>>> as soon as we're on github they will be created automatically):
>>> upload both webrev.2_to_3 and webrev.3 .
>> I appreciate this mercurial tip, it is very helpful. Even though I may not
>> need it anymore :)
>>> Also, this is your second patch, isn't it? I can sponsor this one, but
>>> please apply for authorship after that :)
>> Thank you for your sponsorship :) I will apply for authorship after this.
>>>>>> I will do some perf checking.
>>>>> Please let me know if you have any findings. Thank you!
>>>> All good with our standard benchmarks. I forgot to do regression testing
>>>> (tier1-5) yesterday, is running with the new patch. I'll shout if
>>>> there's an issue.
>>> All good afaics.
>> Great, thanks for checking.
> lgtm. Thanks.
More information about the hotspot-gc-dev