RFR: 8251570: 8215624 causes assert(worker_id <' _n_workers) failed: Invalid worker_id(Internet mail)

Stefan Karlsson stefan.karlsson at oracle.com
Mon Aug 17 07:08:57 UTC 2020


Hi Lin,

On 2020-08-15 01:24, linzang(臧琳) wrote:
> Hi Stefan,
>      Thanks for help fix the issue. Sorry for not realize this bug in 
> original patch.
> 
>> Note that even if the user tries to specify the Number of threads to use for the parallel heap inspection, there's no guarantee at all that we'll use that many threads.  I didn't change that with this patch, but I'm not sure if that was 
> apparent for the authors and reviewers of 8215624 <tel:8215624>.
> 
>       I considered the parallel heap inspection thread number has same 
> behavior with ‘parallelGCThreads‘. And I think it is reasonable that 
> user may not be guaranteed to get as many threads as they want.

OK. Good to know.

Thanks,
StefanK

> 
> Thanks,
> Lin
> 
>> On Aug 15, 2020, at 4:05 AM, Stefan Karlsson 
>> <stefan.karlsson at oracle.com> wrote:
>>
>> Thanks, Kim!
>>
>> StefanK
>>
>> On 2020-08-14 21:26, Kim Barrett wrote:
>>>> On Aug 14, 2020, at 2:25 PM, Stefan Karlsson 
>>>> <stefan.karlsson at oracle.com> wrote:
>>>> https://cr.openjdk.java.net/~stefank/8251570/webrev.02.delta/
>>>> https://cr.openjdk.java.net/~stefank/8251570/webrev.02/
>>> Still looks good.  That is, I don’t see anything wrong with this one 
>>> either.
>>


More information about the hotspot-gc-dev mailing list