RFR (M): 8245721: Refactor the TaskTerminator

Leo Korinth leo.korinth at oracle.com
Mon Aug 17 07:59:04 UTC 2020


Looks good.

Thanks,
Leo

On 14/08/2020 16:13, Thomas Schatzl wrote:
> Hi Kim,
> 
> On 14.08.20 16:00, Kim Barrett wrote:
>>> On Aug 14, 2020, at 6:22 AM, Thomas Schatzl <thomas.schatzl at oracle.com> wrote:
>>>
>>> Hi Kim,
>>>
>>>   sorry for that .1 webrev, it was sent out in a hurry and so it got messed up.
>>>
>>> Here's what has originally been intended to be posted:
>>>
>>> http://cr.openjdk.java.net/~tschatzl/8245721/webrev.2/ (full)
>>> http://cr.openjdk.java.net/~tschatzl/8245721/webrev.1_to_2/ (diff)
>>>
>>> I took some time because of vacations and some more perf testing that had to wait a bit due to the machine being occupied (no issues afaics).
>>>
>>> We also talked about potential improvements/changes in this thread and also in private: I summarized the less crazy ones in https://bugs.openjdk.java.net/browse/JDK-8251833
>>
>> Looks good.
>>
> 
>    thanks for your review.
> 
> Thomas


More information about the hotspot-gc-dev mailing list