RFR: 8252367: Undo JDK-8245000: Windows GDI functions don't support large pages

Stefan Karlsson stefan.karlsson at oracle.com
Mon Aug 31 08:54:40 UTC 2020


Thanks, Erik.

StefanK

On 2020-08-31 10:41, Erik Österlund wrote:
> Hi Stefan,
>
> Looks good.
>
> Thanks,
> /Erik
>
> On 2020-08-26 13:52, Stefan Karlsson wrote:
>> Hi all,
>>
>> Please review this patch to re-enable large pages on Windows.
>>
>> https://cr.openjdk.java.net/~stefank/8252367/webrev.01/
>> https://bugs.openjdk.java.net/browse/JDK-8252367
>>
>> In JDK 15 we put in code that turns off large pages if it is detected 
>> that Windows GDI functions don't work with large pages. Later in JDK 
>> 16, and JDK 15.0.1, the code that uses GDI was rewritten to have a 
>> fallback mechanism for these kinds of problems (JDK-8240654). Because 
>> of that we don't need the workaround to turn off large pages anymore.
>>
>> We also pushed a similar workaround patch to turn off NUMA 
>> interleaving (JDK-8245002). That will be dealt with in a separate RFR 
>> (JDK-8252368).
>>
>> I tested locally that the reproducer in JDK-8245000 doesn't reproduce 
>> with the proposed patch. I also tested that also reverting the patch 
>> in JDK-8240654 causes reproducer to reproduce again.
>>
>> Thanks,
>> StefanK
>



More information about the hotspot-gc-dev mailing list