RFR: 8252368 : Undo JDK-8245002: Windows GDI functions don't support NUMA interleaving

Stefan Karlsson stefan.karlsson at oracle.com
Mon Aug 31 08:55:09 UTC 2020


Thanks, StefanJ

StefanK

On 2020-08-31 10:52, stefan.johansson at oracle.com wrote:
> Hi StefanK,
>
> Looks good,
> StefanJ
>
> On 2020-08-26 13:53, Stefan Karlsson wrote:
>> Hi all,
>>
>> Please review this patch to re-enable NUMA interleaving on Windows.
>>
>> https://cr.openjdk.java.net/~stefank/8252368/webrev.01/
>> https://bugs.openjdk.java.net/browse/JDK-8252368
>>
>> In JDK 15 we put in code that turns off NUMA interleaving if it is 
>> detected that Windows GDI functions don't work with split memory 
>> reservations. Later in JDK 16, and JDK 15.0.1, the code that uses GDI 
>> was rewritten to have a fallback mechanism for these kinds of 
>> problems (JDK-8240654). Because of that we don't need the workaround 
>> to turn off NUMA interleaving anymore.
>>
>> We also pushed a similar workaround patch to turn off large pages 
>> (JDK-8245000). That is dealt with in a separate RFR (JDK-8252367). 
>> This patch builds upon the changes in JDK-8252367.
>>
>> I tested locally that the reproducer in JDK-8245000 doesn't reproduce 
>> with the proposed patch. I also tested that also reverting the patch 
>> in JDK-8240654 causes reproducer to reproduce again.
>>
>> Thanks,
>> StefanK



More information about the hotspot-gc-dev mailing list