RFR: 8252141: Rename G1YoungRemSetSamplingThread to better reflect its purpose

Thomas Schatzl thomas.schatzl at oracle.com
Mon Aug 31 13:20:13 UTC 2020


Hi,

On 26.08.20 09:18, stefan.johansson at oracle.com wrote:
> Hi Kim,
> 
> Thanks for reviewing.
> 
> On 2020-08-25 04:44, Kim Barrett wrote:
>>> On Aug 24, 2020, at 5:36 PM, stefan.johansson at oracle.com wrote:
>>>
>>> Hi,
>>>
>>> Please review this rename of the G1 Young RemSet Sampling thread.
>>>[...]
> Nice catch, updated in:
> Full: http://cr.openjdk.java.net/~sjohanss/8252141/01/
> Inc: http://cr.openjdk.java.net/~sjohanss/8252141/00-01/
> 
> I also filed a issue to take care of the name at some point:
> https://bugs.openjdk.java.net/browse/JDK-8252358

Thanks.

Some comments:

- g1RemSetSummary.cpp:330:

   out->print_cr("  Concurrent sampling threads times (s)");
   out->print_cr("         %5.2f", service_thread_vtime());

should probably be "Service thread time (s)".

- if you are bored, some copyright dates need updates

- pre-existing: maybe the includes in G1ServiceThread.hpp could be 
fixed; at least runtime/mutex.hpp should be included for Monitor.

Thanks,
   Thomas


More information about the hotspot-gc-dev mailing list