RFR (S): 8238220: Rename OWSTTaskTerminator to TaskTerminator

Thomas Schatzl thomas.schatzl at oracle.com
Mon Feb 3 09:53:41 UTC 2020


Hi Sangheon, Stefan,

On 31.01.20 18:54, sangheon.kim at oracle.com wrote:
> Hi Thomas,
> 
> On 1/31/20 2:41 AM, Thomas Schatzl wrote:
>> Hi Sangheon,
>>
>> On 30.01.20 19:08, sangheon.kim at oracle.com wrote:
>>> Hi Thomas,
>>>
>>> On 1/30/20 3:34 AM, Thomas Schatzl wrote:
>>>> Hi all,
>>>>
>>>>   can I have reviews for this renaming change of OWSTTaskTerminator 
>>>> to TaskTerminator now that there is only one task termination 
>>>> protocol implementation?
>>>>
>>>> I believe that the OWST prefix only makes the code harder to read 
>>>> without conveying interesting information at the uses.
>>>>
>>>> Based on JDK-8215297.
>>>>
>>>> CR:
>>>> https://bugs.openjdk.java.net/browse/JDK-8238220
>>>> Webrev:
>>>> http://cr.openjdk.java.net/~tschatzl/8238220/webrev/
>>> Looks good as is.
>>>
>>> One thing to note is the order of renamed header file.
>>> It looks like you are treating uppercase first? :)
>>>
>>> e.g. at g1CollectedHeap.cpp
>>>
>>> +#include "gc/shared/taskTerminator.hpp"
>>>   #include "gc/shared/taskqueue.inline.hpp"
>>>
>>>
>>> I expect alphabet order first and then upper-lowercase. :)
>>>
>>
>>   by default, upper case sorts before lower case in many if not all 
>> situations on computers since typically all upper case letters are 
>> "before" lower case letters in character sets.
>>
>> I would like to keep it as is unless you or somebody else really 
>> objects - there does not seem to be a precedence in hotspot files.
> I'm fine with current order.
> As you said personally, hotspot style just says "Keep the include lines 
> sorted".
> 
> https://wiki.openjdk.java.net/display/HotSpot/StyleGuide
> 
> Thanks,
> Sangheon
> 

   thanks for your reviews.

Thomas



More information about the hotspot-gc-dev mailing list