RFR(XS): 8238932: Invalid tier1_gc_1 test group definition

Kim Barrett kim.barrett at oracle.com
Wed Feb 12 18:47:36 UTC 2020


> On Feb 12, 2020, at 12:27 PM, Mikael Vidstedt <mikael.vidstedt at oracle.com> wrote:
> 
> 
> Please review this small change which fixes the definition of the tier1_gc_1 jtreg test group.
> 
> JBS: https://bugs.openjdk.java.net/browse/JDK-8238932
> Webrev: http://cr.openjdk.java.net/~mikael/webrevs/8238932/webrev.00/open/webrev/
> 
> The issue was introduced as part of JDK-8212657[1] "Promptly Return Unused Committed Memory from G1”. The missing backslash means "-gc/g1/TestTimelyCompaction.java” will actually be interpreted as a test group name by jtreg, resulting in an empty test group. There is no TestTimelyCompaction.java test/file, so either it was not added, or it’s really supposed to be test/hotspot/jtreg/gc/g1/TestPeriodicCollection.java (which was added as part of the same change).
> 
> In either case, since the test group definition has been used successfully for more than a year now it seems like simply removing the faulty line should do the trick..?
> 
> Cheers,
> Mikael
> 
> [1] https://bugs.openjdk.java.net/browse/JDK-8212657

Looks good, and trivial.

Maybe someone should contact the original authors of the change regarding the possibly missing test.



More information about the hotspot-gc-dev mailing list