RFR: JDK-8239081: Shenandoah: Consolidate C1 LRB and native barriers

Aleksey Shipilev shade at redhat.com
Mon Feb 17 08:12:18 UTC 2020


On 2/15/20 1:35 PM, Roman Kennke wrote:
>>> https://bugs.openjdk.java.net/browse/JDK-8239081
>>> Webrev:
>>> http://cr.openjdk.java.net/~rkennke/JDK-8239081/webrev.00/
>>
>> Only some stylistic nits:
>>
>> *) I believe the convention is to name these boolean arguments "is_native"?
>>
>> *) C1ShenandoahLoadReferenceBarrierCodeGenClosure::_native should probably be const?
> 
> Right, good points! Both fixed here:
> 
> http://cr.openjdk.java.net/~rkennke/JDK-8239081/webrev.01/

I think variables and fields should be "is_native" too.

Here:

 216     bool native = ShenandoahBarrierSet::use_load_reference_barrier_native(decorators, type);
 217     tmp = load_reference_barrier(gen, tmp, access.resolved_addr(), native);

...and here:

 255 class C1ShenandoahLoadReferenceBarrierCodeGenClosure : public StubAssemblerCodeGenClosure {
 256 private:
 257   const bool _native;

...and here:

  89 class ShenandoahLoadReferenceBarrierStub: public CodeStub {
  ...
  97   bool _native;

...and probably somewhere else too?

-- 
Thanks,
-Aleksey



More information about the hotspot-gc-dev mailing list