RFR: JDK-8237780: Shenandoah: More reliable nmethod verification

Zhengyu Gu zgu at redhat.com
Tue Feb 18 12:54:32 UTC 2020



On 2/17/20 10:27 AM, Roman Kennke wrote:
>>>>> http://cr.openjdk.java.net/~rkennke/JDK-8237780/webrev.01/
>>>>
>>>> This is fine.
>>>>
>>>> Although I would probably be open for storing that diagnostics into
>>>> stringStream (see how
>>>> ShenandoahAsserts::print_failure does it), and putting it into the
>>>> fatal message itself. Pros:
>>>> customers would hand over hs_errs to us with the relevant
>>>> diagnostics. Cons: we can overflow the
>>>> stringStream and truncate parts of the data. Your call.
>>>
>>>
>>> Ok, let's do that then:
>>>
>>> http://cr.openjdk.java.net/~rkennke/JDK-8237780/webrev.02/
>>>
>>> Good?
>>
>> assert_same_oops() itself is assert only (has NOT_DEBUG_RETURN in
>> definition), does not need nested ifdef ASSERT ...
> 
> 
> Right! Very good catch!
> 
> http://cr.openjdk.java.net/~rkennke/JDK-8237780/webrev.03/
> 
> Good now?
> 
Yes, good to me.

Thanks,

-Zhengyu

> Thanks for reviewing!
> 
> Roman
> 



More information about the hotspot-gc-dev mailing list