[14] RFR (S): 8235934: gc/g1/TestGCLogMessages.java fails with 'DerivedPointerTable Update' found

Thomas Schatzl thomas.schatzl at oracle.com
Tue Jan 7 10:41:38 UTC 2020


Hi Kim,

   thanks for your review.

On 31.12.19 08:09, Kim Barrett wrote:
>> On Dec 17, 2019, at 4:27 AM, Thomas Schatzl <thomas.schatzl at oracle.com> wrote:
>>
>> Hi all,
>>
>>   can I have reviews for this testbug where there is a mismatch between "C2 compiler is enabled" and "C2 compiler is compiled in" in verifying output messages.
>>
>> I.e. G1 prints some additional log messages if the C2 compiler is compiled in, but the test checks this message for (non-)existence if the C2 compiler is enabled.
>>
>> Since there are a few flags that can toggle compiler use even when compiled in (UseCompiler, TieredStopAtLevel<=3, ...) the GC prints that message but the test does not expect it.
>>
>> The fix is to add a whitebox method that specifically returns whether the C2 compiler is compiled in or not, to be used by the test.
>>
>> I would like to push this to 14 even if it is P4 because of the test bug exemption, returning unnecessary reproducable errors.
>>
>> CR:
>> https://bugs.openjdk.java.net/browse/JDK-8235934
>> Webrev:
>> http://cr.openjdk.java.net/~tschatzl/8235934/webrev/
>> Testing:
>> hs-tier1-3, local runs of TestGCLogMessages.java
>>
>> Thanks,
>>   Thomas
> 
> ------------------------------------------------------------------------------
> src/hotspot/share/prims/whitebox.cpp
> 1990 #if COMPILER2_OR_JVMCI
> 1991   return true;
> 1992 #else
> 1993   return false;
> 1994 #endif
> 
> This could perhaps be just
> 
>    return bool(COMPILER_OR_JVMCI);
> 
> That will fail to compile if COMPILER_OR_JVMCI is not defined at all;
> not sure whether that's a pro or con for this alternative form.

I do not have an opinion, so kept it as is.

> ------------------------------------------------------------------------------
> src/hotspot/share/prims/whitebox.cpp
> 1989 WB_ENTRY(jboolean, WB_isC2OrGraalIncludedInVmBuild(JNIEnv* env))
> 
> I think the name ought to use "Jvmci" rather than "Graal".
> 
> ------------------------------------------------------------------------------
> 

Fixed.

http://cr.openjdk.java.net/~tschatzl/8235934/webrev.0_to_1 (diff)
http://cr.openjdk.java.net/~tschatzl/8235934/webrev.1 (full)

Tested locally.

Thanks,
   Thomas


More information about the hotspot-gc-dev mailing list