[15] RFR 8236878: Use atomic instruction to update StringDedupTable's entries and entries_removed counters

Aleksey Shipilev shade at redhat.com
Thu Jan 16 08:51:42 UTC 2020


On 1/15/20 10:29 PM, Zhengyu Gu wrote:
> Updated webrev: 
> http://cr.openjdk.java.net/~zgu/JDK-8236878/webrev.01/index.html

OK, thanks for explaining. I guess that makes sense.

This comment is outdated then:
   480   // Delayed update to avoid contention on the table lock

I'd suggest to rewrite it to:
  // Do atomic update here instead of taking StringDedupTable_lock. This allows concurrent
  // cleanup when multiple workers are cleaning up the table, while the mutators are blocked
  // on StringDedupTable_lock.

...or some such.

-- 
Thanks,
-Aleksey



More information about the hotspot-gc-dev mailing list