RFR (M): 8235860: Obsolete the UseParallelOldGC option

Leo Korinth leo.korinth at oracle.com
Thu Jan 16 16:06:29 UTC 2020


Hi!

I believe _name and old_gen_name() in PSOldGen should be removed and the 
virtual name() should return the string literal directly. Change this if 
you want.

With or without using my suggestions, your changes looks good to me.

Thanks for cleaning this!
Leo

On 07/01/2020 11:55, Thomas Schatzl wrote:
> Hi Kim,
> 
> On 18.12.19 16:45, Kim Barrett wrote:
>>
>>
>>> On Dec 18, 2019, at 4:52 AM, Thomas Schatzl 
>>> <thomas.schatzl at oracle.com> wrote:
>>>
>>> Fixed in
>>> http://cr.openjdk.java.net/~tschatzl/8235860/webrev.0_to_1 (diff)
>>> http://cr.openjdk.java.net/~tschatzl/8235860/webrev.1 (full)
>>
>> Looks good.
>>
> 
> Thanks for your review.
> 
>>>
>>>> ------------------------------------------------------------------------------ 
>>>>
>>>> src/hotspot/share/gc/parallel/psParallelCompact.hpp
>>>> Pre-existing: It seems like the big block comment before SplitInfo
>>>> should have received some updates as part of the recent shadow-region
>>>> patch, but it wasn't touched.
>>>> ------------------------------------------------------------------------------ 
>>>>
>>>
>>> I am filing a CR for that.
>>
>> The comment before PSParallelCompact in the same file might also need 
>> some updating.
>>
>> (I was a bit confused in my earlier review about where the relevant 
>> comments were.)
>>
> 
>    I filed JDK-8141637 before the holidays. I added your recent comment.
> 
> Thanks,
>    Thomas


More information about the hotspot-gc-dev mailing list