[14] RFR (S): 8237079: gc/g1/mixedgc/TestLogging.java fails with "Pause Young (Mixed) (G1 Evacuation Pause) not found"

Thomas Schatzl thomas.schatzl at oracle.com
Fri Jan 17 16:55:13 UTC 2020


Hi,

On Fri, 2020-01-17 at 16:07 +0100, Leo Korinth wrote:
> Hi Thomas,
> 
> This is not a review. This code is basically the same code as is 
> duplicated at least three times in the test code. One of the 
> duplications you can blame me for, *sorry*. I believe it should be
> moved 
> to a common library method. I also believe the last fix you did in 
> TestG1ParallelPhases.java makes that version look cleaner than what
> you 
> propose here (it does not need the last allocation loop at all).

I figured that this code looked familiar but did not know where I saw
that before. I should have looked through the other tests.... let me
look at the other implementations and redo this change.

> 
> How about using the TestG1ParallelPhases.java version for all three
> test cases? If not, do the third version in TestOldGenCollectionUsage
> really work???

I will check it out.

Thomas




More information about the hotspot-gc-dev mailing list