[14] RFR (S): 8237079: gc/g1/mixedgc/TestLogging.java fails with "Pause Young (Mixed) (G1 Evacuation Pause) not found"

Thomas Schatzl thomas.schatzl at oracle.com
Wed Jan 22 16:14:10 UTC 2020


Hi Leo,

On 22.01.20 17:02, Leo Korinth wrote:
> On 22/01/2020 11:46, Thomas Schatzl wrote:
>> Hi all,
>>
>> On 17.01.20 16:07, Leo Korinth wrote:
>>> Hi Thomas,
>>>
>>> This is not a review. This code is basically the same code as is 
>>
[...]
>>>
>>> How about using the TestG1ParallelPhases.java version for all three 
>>> test cases? If not, do the third version in TestOldGenCollectionUsage 
>>> really work???
>>>
>>
>> Here's a webrev incorporating these suggestions to unify the code:
>>
>> http://cr.openjdk.java.net/~tschatzl/8237079/webrev.1 (full)
> 
>>
>> There is no point to provide a diff webrev here as the whole change 
>> has been redone.
>>
[...]
> 
> I think this looks *really* good. Also, thanks for taking the extra time 
> to make it shared and reusable code.
> 
> /Leo

Thanks for your review.

Thomas



More information about the hotspot-gc-dev mailing list