RFR (XS): 8238229: Remove TRACESPINNING debug code

Thomas Schatzl thomas.schatzl at oracle.com
Thu Jan 30 11:56:53 UTC 2020


Hi all,

   can I have reviews for this removal of some debug code in the 
TaskTerminator class?

The code counts the total number of yields/peeks/spins during task 
termination. Since it is guarded by a define, the code is not included 
in any regular build, so there is potential for bit-rotting.

Since the code is not very complicated (and I believe it is too simple 
for real measurements), and needs rebuild anyway for use I propose to 
just remove it instead of trying to improve it for unknown requirements.

Based on JDK-8238220.

CR:
https://bugs.openjdk.java.net/browse/JDK-8238229
Webrev:
http://cr.openjdk.java.net/~tschatzl/8238229/webrev/
Testing:
local compilation

Thanks,
   Thomas


More information about the hotspot-gc-dev mailing list