RFR (M): 8215297: Remove ParallelTaskTerminator

Stefan Johansson stefan.johansson at oracle.com
Thu Jan 30 15:47:36 UTC 2020


Hi Thomas,

On 2020-01-30 11:45, Thomas Schatzl wrote:
> Hi Zhengyu,
> 
> On 29.01.20 14:45, Zhengyu Gu wrote:
>> Hi Thomas,
>>
>> Shared changes look good to me.
> 
>    thanks for your review; I touched up the files a little in
> 
> http://cr.openjdk.java.net/~tschatzl/8215297/webrev.0_to_1 (diff)
> http://cr.openjdk.java.net/~tschatzl/8215297/webrev.1 (full)
Seems to be some webrev-hickup with webrev.1, but I guess nothing 
changed in g1ConcurrentMark.cpp since first webrev so looked there instead.

Looks good, especially after the follow-up patches.

Thanks,
StefanJ

> 
> slightly after some feedback and finding some minor (pre-existing) issues.
> 
>>
>> I filed follow-up CR(JDK-8238162) to remove ShenandoahTaskTerminator 
>> wrapper.
> 
> Okay.
> 
> Thanks,
>    Thomas


More information about the hotspot-gc-dev mailing list