RFR (XS): 8238229: Remove TRACESPINNING debug code
thomas.schatzl at oracle.com
Thu Jan 30 16:43:16 UTC 2020
On 30.01.20 16:24, Stefan Johansson wrote:
> Looks good,
all fixed. Idk why these were missing in that webrev, I regenerated it.
> On 2020-01-30 12:56, Thomas Schatzl wrote:
>> Hi all,
>> can I have reviews for this removal of some debug code in the
>> TaskTerminator class?
>> The code counts the total number of yields/peeks/spins during task
>> termination. Since it is guarded by a define, the code is not included
>> in any regular build, so there is potential for bit-rotting.
>> Since the code is not very complicated (and I believe it is too simple
>> for real measurements), and needs rebuild anyway for use I propose to
>> just remove it instead of trying to improve it for unknown requirements.
>> Based on JDK-8238220.
> I agree that this can be removed, and there is even more code that
> should go. The call from each collected heap:
> src/hotspot/share/gc/shared/genCollectedHeap.cpp:680:#ifdef TRACESPINNING
> src/hotspot/share/gc/parallel/psScavenge.cpp:734:#ifdef TRACESPINNING
> src/hotspot/share/gc/g1/g1CollectedHeap.cpp:1135:#ifdef TRACESPINNING
> src/hotspot/share/gc/g1/g1CollectedHeap.cpp:3143:#ifdef TRACESPINNING
> Otherwise, looks good,
>> local compilation
More information about the hotspot-gc-dev