RFR (M): 8210462: Fix remaining mentions of initial mark

Leo Korinth leo.korinth at oracle.com
Thu Jul 2 21:43:12 UTC 2020



On 30/06/2020 16:21, Thomas Schatzl wrote:
> Hi all,
> 
>    can I have reviews for this change that removes remaining use of the 
> "initial mark pause" to the "newer" concurrent start in the code?
> 
> This is mostly a straightforward s/initial mark/concurrent start/ 
> replacement.

Changes looks mostly good to me.

in: src/hotspot/share/gc/g1/g1Policy.cpp
After initializing the variable "this_pause", maybe use it instead of young_gc_pause_kind() two statements below?

in: src/hotspot/share/gc/g1/g1Policy.hpp
#include "gc/g1/g1HeapRegionAttr.hpp"
#include "gc/g1/g1ConcurrentStartToMixedTimeTracker.hpp"
#include "gc/g1/g1MMUTracker.hpp"
(no longer sorted after renaming)

in: src/hotspot/share/gc/g1/g1InitialMarkToMixedTimeTracker.hpp
#include "utilities/globalDefinitions.hpp"
#include "utilities/debug.hpp"
(not sorted, pre-existing)

Some grepping (egrep -Ri "initial.?mark") shows more potential changes in:
open/src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/shared/GCCause.java:  _cms_initial_mark ("CMS Initial Mark"),
(oops, my fault, I should have removed it with CMS)

open/src/hotspot/share/gc/g1/g1CollectedHeap.inline.hpp:    res |= G1EvacuationFailureALotDuringInitialMark;
open/src/hotspot/share/gc/g1/g1_globals.hpp:  develop(bool, G1EvacuationFailureALotDuringInitialMark, true,             \
(maybe not rename the flag, unsure about the amount of work when it is a developer flag, just want to mention it)

open/src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/shared/G1YCType.java:  InitialMark ("Initial Mark"),
open/src/hotspot/share/gc/g1/g1Policy.cpp:    assert(!is_concurrent_start_pause(this_pause), "The young GC before mixed is not allowed to be an initial mark GC");
open/src/hotspot/share/gc/g1/g1CollectedHeap.cpp:    // Try to schedule an initial-mark evacuation pause that will
open/src/hotspot/share/gc/g1/g1CollectedHeap.cpp:      // collection an initial-mark won't be honored.  If we don't check for
open/src/hotspot/share/gc/g1/g1CollectedHeap.cpp:  // We do not allow initial-mark to be piggy-backed on a mixed GC.
open/test/hotspot/gtest/gc/shared/test_preservedMarks.cpp:  // Make sure initial marks are correct.
open/test/hotspot/jtreg/gc/g1/TestGCLogMessages.java:        new TestGCLogMessages().testWithInitialMark();
open/test/hotspot/jtreg/gc/g1/TestGCLogMessages.java:    private void testWithInitialMark() throws Exception {
open/test/hotspot/jtreg/gc/g1/TestGCLogMessages.java:                                                                  GCTestWithInitialMark.class.getName());
open/test/hotspot/jtreg/gc/g1/TestGCLogMessages.java:    static class GCTestWithInitialMark {
open/test/hotspot/jtreg/gc/g1/TestHumongousAllocInitialMark.java: * @test TestHumongousAllocInitialMark
open/test/hotspot/jtreg/gc/g1/TestHumongousAllocInitialMark.java: * @run driver gc.g1.TestHumongousAllocInitialMark
open/test/hotspot/jtreg/gc/g1/TestHumongousAllocInitialMark.java:public class TestHumongousAllocInitialMark {

Thanks,
Leo



> CR:
> https://bugs.openjdk.java.net/browse/JDK-8210462
> Webrev:
> http://cr.openjdk.java.net/~tschatzl/8210462/webrev/
> Testing:
> tier1-5
> 
> Thanks,
>    Thomas


More information about the hotspot-gc-dev mailing list