RFR [15] : 8249037 : clean up FileInstaller $test.src $cwd in vmTestbase_vm_g1classunloading tests

Kim Barrett kim.barrett at oracle.com
Thu Jul 9 15:04:00 UTC 2020


> On Jul 8, 2020, at 10:39 PM, Igor Ignatyev <igor.ignatyev at oracle.com> wrote:
> 
> http://cr.openjdk.java.net/~iignatyev//8249037/webrev.00
>> 112 lines changed: 0 ins; 112 del; 0 mod;
> 
> Hi all,
> 
> could you please review the patch which removes `FileInstaller . .` jtreg action from :vmTestbase_vm_g1classunloading tests?
> from the main issue(8204985):
>> all vmTestbase tests have '@run driver jdk.test.lib.FileInstaller . .' to mimic old test harness behavior and copy all files from a test source directory to a current work directory. some tests depend on this step, so we need 1st identify such tests and then either rewrite them not to have this dependency or leave FileInstaller only in these tests.
> 
> the patch is as simple as `ag -l  '@run driver jdk.test.lib.FileInstaller . .' vmTestbase/gc/g1/unloading/tests | xargs -I{} gsed -i '/@run driver jdk.test.lib.FileInstaller \. \./d' {}`
> 
> testing: :vmTestbase_vm_g1classunloading on linux-x64
> webrev: http://cr.openjdk.java.net/~iignatyev//8249037/webrev.00
> JBS: https://bugs.openjdk.java.net/browse/JDK-8249037
> 
> Thanks,
> -- Igor

Looks good.

I wonder though, why target this cleanup to JDK 15?



More information about the hotspot-gc-dev mailing list