RFR [15] : 8249038 : clean up FileInstaller $test.src $cwd in vmTestbase_vm_gc tests

Kim Barrett kim.barrett at oracle.com
Fri Jul 10 01:15:04 UTC 2020


> On Jul 9, 2020, at 1:44 PM, Igor Ignatyev <igor.ignatyev at oracle.com> wrote:
> 
> http://cr.openjdk.java.net/~iignatyev//8249038/webrev.00
>> 267 lines changed: 1 ins; 264 del; 2 mod;
> 
> Hi all,
> 
> could you please review the patch which removes `FileInstaller . .` jtreg action from :vmTestbase_vm_gc tests?
> from the main issue(8204985):
>> all vmTestbase tests have '@run driver jdk.test.lib.FileInstaller . .' to mimic old test harness behavior and copy all files from a test source directory to a current work directory. some tests depend on this step, so we need 1st identify such tests and then either rewrite them not to have this dependency or leave FileInstaller only in these tests.
> 
> the biggest part of the patch is just `ag -l  '@run driver jdk.test.lib.FileInstaller . .' vmTestbase/gc/ vmTestbase/vm/gc  | xargs -I{} gsed -i '/@run driver jdk.test.lib.FileInstaller \. \./d' {}`. the only test which depended on FileInstaller was vmTestbase/gc/gctests/fileTest, this test has been updated to search for the specified file in Utils.TEST_SRC directory.
> 
> testing: 
> - :vmTestbase_vm_gc on linux-x64
> - vmTestbase/gc/gctests/fileTest on {linux,windows,macos}-x64
> webrev: http://cr.openjdk.java.net/~iignatyev//8249038/webrev.00
> JBS: https://bugs.openjdk.java.net/browse/JDK-8249038
> 
> Thanks,
> -- Igor

Looks good.



More information about the hotspot-gc-dev mailing list