RFR: 8249225 - Move definition of PADDING_ELEM_NUM

Cesar Soares Lucas Divino.Cesar at microsoft.com
Thu Jul 23 21:39:05 UTC 2020


Hi Thomas and Kim, thanks for reviewing!

Here is the updated Webrev: https://cr.openjdk.java.net/~adityam/cesar/8249225_1/

Yes, I do need someone to commit this for me.


Cheers,
Cesar


From: hotspot-gc-dev <hotspot-gc-dev-retn at openjdk.java.net> on behalf of Kim Barrett <kim.barrett at oracle.com>
Sent: July 23, 2020 3:51 AM
To: Thomas Schatzl <thomas.schatzl at oracle.com>
Cc: hotspot-gc-dev at openjdk.java.net <hotspot-gc-dev at openjdk.java.net>
Subject: Re: RFR: 8249225 - Move definition of PADDING_ELEM_NUM 
 
> On Jul 23, 2020, at 6:24 AM, Thomas Schatzl <thomas.schatzl at oracle.com> wrote:
> 
> Hi,
> 
> On 21.07.20 03:41, Cesar Soares Lucas wrote:
>> Bug: https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugs.openjdk.java.net%2Fbrowse%2FJDK-8249225&data=02%7C01%7Cdivino.cesar%40microsoft.com%7Cbd9e6881086d46ee824408d82ef68fd3%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637310983797971949&sdata=DaaUE212nQkJID064Hz3GlsAsANb5f1u0KkCYslbZfw%3D&reserved=0
>> Webrev: https://nam06.safelinks.protection.outlook.com/?url=http:%2F%2Fcr.openjdk.java.net%2F~adityam%2Fcesar%2F8249225%2F&data=02%7C01%7Cdivino.cesar%40microsoft.com%7Cbd9e6881086d46ee824408d82ef68fd3%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637310983797981947&sdata=uQ0uwQwW7lEpbO8FZQNq%2BA3ijoB%2FzHhKxX5qytj%2FrTI%3D&reserved=0
>> Please review the above linked patch for the mentioned bug. It's a small change
>> that moves the definition of "PADDING_ELEM_NUM" to the only file that uses it.
>> I also took the chance of converting it from a "#define" directive into a "const"
>> declaration - I can revert it back to a #define if you think it's better.
> 
>  could the change please re-add the newline after array_length? It is easier to read if generation of the constants is slightly offset from the other code.
> 
> Looks good otherwise. I do not need a re-review for this change.

Looks good to me too, with that re-added newline.

> Do you need a sponsor?
> 
> Thanks,
>  Thomas



More information about the hotspot-gc-dev mailing list