RFR[XXS] 8248672: utilities: Introduce DEPRECATED macro for GCC and MSVC

Kim Barrett kim.barrett at oracle.com
Fri Jul 24 23:42:43 UTC 2020


> On Jul 24, 2020, at 12:41 PM, Ludovic Henry <luhenry at microsoft.com> wrote:
> 
> I'm not sure I understand your question. Are you asking whether I also replaced all uses of __attribute__((deprecated)) with DEPRECATED? If so, I did replace the only use of it [1] together with defining the macro.
> 
> Please let me know if I misunderstood your question.
> 
> Thank you.
> 
> --
> Ludovic
> 
> [1] in src/hotspot/cpu/aarch64/macroAssembler_aarch64.hpp.

Why are we deprecating something rather than just deleting it and
fixing any users?

If the point is to keep the overload but prevent it from being called,
there are better ways than a deprecation warning.

And if we *really* needed deprecation warnings, I suggest using the
C++14 [[deprecated]] attribute (after adding it to the approved new
feature list).  But I think we shouldn't be doing this at all.



> 
> ________________________________________
> From: Vladimir Kozlov <vladimir.kozlov at oracle.com>
> Sent: Friday, July 24, 2020 09:02
> To: Ludovic Henry; hotspot-compiler-dev at openjdk.java.net; aarch64-port-dev at openjdk.java.net
> Cc: openjdk-aarch64; hotspot-gc-dev at openjdk.java.net
> Subject: Re: RFR[XXS] 8248672: utilities: Introduce DEPRECATED macro for GCC and MSVC
> 
> "And use it in the AArch64 sub system."
> 
> Can you explain more? Do you have RFE filed for DEPRECATED use?
> It is small change which usually done together with usage. Why do this separately?
> 
> Thanks,
> Vladimir K
> 
> On 7/24/20 8:53 AM, Ludovic Henry wrote:
>> Hi,
>> 
>> Could I please have a review on the following. It simply adds the `DEPRECATED` macro to wrap `__attribute__ ((deprecated))` for GCC, and the equivalent for MSVC.
>> 
>> JBS: https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugs.openjdk.java.net%2Fbrowse%2FJDK-8248672&data=02%7C01%7Cluhenry%40microsoft.com%7Cf8e2909451c44ee9c9b108d82feafcd6%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637312033704245529&sdata=p%2Bec5f3YYaazBblPt9vRWjQ2ZWa209lHGPLlsuMbpk8%3D&reserved=0
>> Webrev: https://nam06.safelinks.protection.outlook.com/?url=http:%2F%2Fcr.openjdk.java.net%2F~burban%2Fluhenry%2F8248672%2Fwebrev.00&data=02%7C01%7Cluhenry%40microsoft.com%7Cf8e2909451c44ee9c9b108d82feafcd6%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637312033704245529&sdata=aOC6Xq%2BJExcKQ8oeNew4aZMHZUD2idlTi3tRihRwpjs%3D&reserved=0
>> 
>> Thank you,
>> 
>> --
>> Ludovic




More information about the hotspot-gc-dev mailing list