RFR (S): 8242036: G1 HeapRegionRemSet::_n_coarse_entries could be a bool

Albert Yang albert.m.yang at oracle.com
Tue Jul 28 13:07:01 UTC 2020


Thank you for your review.

On 2020-07-27 11:07, Leo Korinth wrote:
> On 25/07/2020 10:36, Thomas Schatzl wrote:
>> Hi,
>>
>> On 25.07.20 01:34, Kim Barrett wrote:
>>>> On Jul 24, 2020, at 7:37 AM, Albert Yang <albert.m.yang at oracle.com> 
>>>> wrote:
>>>>
>>>> I see.
>>>>
>>>> Updated:
>>>>
>>>> http://cr.openjdk.java.net/~lkorinth/albert/8242036/3/
>>>>
>>>> I am not sure if this unconditional write will pollute the 
>>>> cacheline though, since this variable is accessed concurrently.
>>>
>>> This code is on a rare path and holding the lock.
>>>
>>> Change looks good.
>>>
>>
>> +1.
>>
>> Thomas
>
> Looks good to me too.
>
> Thanks,
> Leo


More information about the hotspot-gc-dev mailing list