RFR: 8246258: Enable hs_err heap printing earlier during initialization

Thomas Stüfe thomas.stuefe at gmail.com
Mon Jun 1 16:04:58 UTC 2020


Hi Stefan,

looks good. Note that there are tests which test very early error handling
(see TestVeryEarlyAssert), you could extend that to guard against bitrot.
But I am fine with the patch as it is.

Cheers, Thomas

On Mon, Jun 1, 2020 at 5:57 PM Stefan Karlsson <stefan.karlsson at oracle.com>
wrote:

> Hi all,
>
> Please review this patch to enable the hs_err GC / heap printing
> directly after the heap has been set up.
>
> https://cr.openjdk.java.net/~stefank/8246258/webrev.01/
> https://bugs.openjdk.java.net/browse/JDK-8246258
>
> Changes in the patch:
> - Remove the Universe::is_fully_initialized
> - Add NULL initializations and checks in print paths
>
> I tested this patch by adding a temporary fatal(...) here:
>
> jint Universe::initialize_heap() {
>    assert(_collectedHeap == NULL, "Heap already created");
>    _collectedHeap = GCConfig::arguments()->create_heap();
>    // <<<< HERE
>    log_info(gc)("Using %s", _collectedHeap->name());
>    return _collectedHeap->initialize();
> }
>
> and manually looking at the result when running with all GCs. Will run
> this through tier1-3.
>
> Thanks,
> StefanK
>


More information about the hotspot-gc-dev mailing list