RFR(S/M) : 8243430 : use reproducible random in :vmTestbase_vm_gc

Igor Ignatyev igor.ignatyev at oracle.com
Tue Jun 2 03:00:18 UTC 2020


ping?
-- Igor

> On May 20, 2020, at 3:43 PM, Igor Ignatyev <igor.ignatyev at oracle.com> wrote:
> 
> ping?
> -- Igor
> 
>> On May 5, 2020, at 10:18 AM, Igor Ignatyev <igor.ignatyev at oracle.com> wrote:
>> 
>> can I get 2nd review for that? or ack. that it's fine to be pushed w/ just one review?
>> 
>> -- Igor
>> 
>>> On May 3, 2020, at 8:29 AM, Igor Ignatyev <igor.ignatyev at oracle.com> wrote:
>>> 
>>> 
>>> 
>>>> On May 3, 2020, at 12:13 AM, Kim Barrett <kim.barrett at oracle.com> wrote:
>>>> 
>>>>> On Apr 30, 2020, at 4:38 PM, Igor Ignatyev <igor.ignatyev at oracle.com> wrote:
>>>>> 
>>>>> http://cr.openjdk.java.net/~iignatyev/8243430/webrev.00
>>>>>> 555 lines changed: 11 ins; 65 del; 479 mod;
>>>>> 
>>>>> Hi all,
>>>>> 
>>>>> could you please review this small patch?
>>>>> from JBS: 
>>>>>> this subtask is to use j.t.l.Utils.getRandomInstance() as a random number generator, where applicable, in : vmTestbase_vm_gc test group and marking the tests which make use of "randomness" with a proper k/w.
>>>>> 
>>>>> testing: : vmTestbase_vm_gc test group
>>>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8243430
>>>>> webrevs:
>>>>> - code changes: http://cr.openjdk.java.net/~iignatyev//8243430/webrev.00.code
>>>>>> 94 lines changed: 11 ins; 65 del; 18 mod;
>>>>> - adding k/w: http://cr.openjdk.java.net/~iignatyev//8243430/webrev.00.kw
>>>>>> 229 lines changed: 0 ins; 0 del; 229 mod; 
>>>>> - full: http://cr.openjdk.java.net/~iignatyev//8243430/webrev.00
>>>>>> 555 lines changed: 11 ins; 65 del; 479 mod;
>>>>> 
>>>>> Thanks,
>>>>> -- Igor
>>>> 
>>> Hi Kim,
>>> 
>>>> I could be missing something, bug I don't see where either of these
>>>> use randomness:
>>>> test/hotspot/jtreg/vmTestbase/gc/gctests/gctest03/gctest03.java
>>> gctest03 starts Yellowthread at L#130, and Yellowthread uses nsk.share.test.LocalRandom in its 'run' method at L#167 of vmTestbase/gc/gctests/gctest03/appthread.java
>>> 
>>>> test/hotspot/jtreg/vmTestbase/gc/gctests/gctest04/gctest04.java
>>> gctest04 starts reqdisp thread at L#97, and reqdisp uses n.s.t.LocalRandom in its 'run' method at L#211 of vmTestbase/gc/gctests/gctest04/reqgen.java
>>>> 
>>>> test/hotspot/jtreg/vmTestbase/gc/gctests/gctest02/gctest02.java
>>>> Still importing java.util.Random, but that doesn't seem needed.
>>>> 53 import java.util.Random;
>>> you're right, I'll remove it before pushing.
>>> 
>>>> 
>>>> Other than that, looks good.
>>> thanks for review!
>>>> 
>>>> I don't need a new webrev for changes related to the above.
>>> 
>>> -- Igor
>>>> 
>>> 
>> 
> 



More information about the hotspot-gc-dev mailing list