RFR: 8247740: Inline derived CollectedHeap access for G1 and ParallelGC

Kim Barrett kim.barrett at oracle.com
Thu Jun 18 02:21:05 UTC 2020


> On Jun 17, 2020, at 1:38 PM, Stefan Karlsson <stefan.karlsson at oracle.com> wrote:
> 
> Looks good.

Thanks.

> Some nits that you might want to consider:
> 
> - Extraneous new line. Other places in the file don't add a newline after public:, private:, or protected:.
> 
> 181 protected:
> 182
> 183 // Must follow Name enum. C++11 forward declaration of enum.
> 
> - I'm not sure the last part is complete. I do understand what it tries to say, but I just don't think it's necessary, or that helpful. A descriptive comment about the function would be more helpful, IMHO.
> 
> // Must follow Name enum. C++11 forward declaration of enum.

I should just file a bug to clean this up later.  I will do that…




More information about the hotspot-gc-dev mailing list