RFR (M): 8247819: G1: Process strong OopStorage entries in parallel

Stefan Karlsson stefan.karlsson at oracle.com
Thu Jun 25 11:28:09 UTC 2020


The formatting looked weird. I'll try again:

Hi Thomas,

This isn't needed after we rewrote the OopStorageSetParState:

+// Needed by _oop_storage_set_strong_par_state as the definition is in the
+// .inline.hpp file.
+G1RootProcessor::~G1RootProcessor() {}

---
This doesn't seem to be used:
  +
  + template <typename Closure>
  + static void strong_oops_do(Closure* cl); };

---
Just a suggestion to lower the noise:
+ G1GCPhaseTimes::GCParPhases phase = 
G1GCPhaseTimes::GCParPhases(G1GCPhaseTimes::StrongOopStorageSetRoots + i);

could be changed to:
+ G1GCPhaseTimes::GCParPhases 
phase(G1GCPhaseTimes::StrongOopStorageSetRoots + i);

Thanks,
StefanK

On 2020-06-25 12:37, Stefan Karlsson wrote:
> Hi Thomas,
>
> This isn't needed after we rewrote the OopStorageSetParState:
>
> +// Needed by _oop_storage_set_strong_par_state as the definition is 
> in the
> +// .inline.hpp file.
> +G1RootProcessor::~G1RootProcessor() {} --- This doesn't seem to be 
> used: + + template <typename Closure> + static void 
> strong_oops_do(Closure* cl); }; --- Just a suggestion to lower the 
> noise: + G1GCPhaseTimes::GCParPhases phase = 
> G1GCPhaseTimes::GCParPhases(G1GCPhaseTimes::StrongOopStorageSetRoots + 
> i); could be changed to: + G1GCPhaseTimes::GCParPhases 
> phase(G1GCPhaseTimes::StrongOopStorageSetRoots + i);
>
>
> Thanks,
> StefanK 



More information about the hotspot-gc-dev mailing list