RFR (M): 8247819: G1: Process strong OopStorage entries in parallel

Thomas Schatzl thomas.schatzl at oracle.com
Thu Jun 25 11:53:07 UTC 2020


Hi Stefan,

   thanks for your review.

On 25.06.20 13:28, Stefan Karlsson wrote:
> The formatting looked weird. I'll try again:
> 
> Hi Thomas,
> 
> This isn't needed after we rewrote the OopStorageSetParState:
> 
> +// Needed by _oop_storage_set_strong_par_state as the definition is in the
> +// .inline.hpp file.
> +G1RootProcessor::~G1RootProcessor() {}

Removed.

> 
> ---
> This doesn't seem to be used:
>   +
>   + template <typename Closure>
>   + static void strong_oops_do(Closure* cl); };

The method is still used by Parallel and Serial GC.

> 
> ---
> Just a suggestion to lower the noise:
> + G1GCPhaseTimes::GCParPhases phase = 
> G1GCPhaseTimes::GCParPhases(G1GCPhaseTimes::StrongOopStorageSetRoots + i);
> 
> could be changed to:
> + G1GCPhaseTimes::GCParPhases 
> phase(G1GCPhaseTimes::StrongOopStorageSetRoots + i);

This does not work (compile). G1GCPhaseTimes::GCParPhases is an enum, 
not a class.

New webrevs:
http://cr.openjdk.java.net/~tschatzl/8247819/webrev.0_to_1/ (diff)
http://cr.openjdk.java.net/~tschatzl/8247819/webrev.1/ (full)

Testing:
recompilation

Thanks,
   Thomas


More information about the hotspot-gc-dev mailing list