RFR (M): 8247819: G1: Process strong OopStorage entries in parallel

Thomas Schatzl thomas.schatzl at oracle.com
Thu Jun 25 13:24:31 UTC 2020


Hi all,

On 25.06.20 13:53, Thomas Schatzl wrote:
> Hi Stefan,
> 
>    thanks for your review.
> 
> On 25.06.20 13:28, Stefan Karlsson wrote:
>> The formatting looked weird. I'll try again:
>>
>> Hi Thomas,
>>
>> This isn't needed after we rewrote the OopStorageSetParState:
>>
>> +// Needed by _oop_storage_set_strong_par_state as the definition is 
>> in the
>> +// .inline.hpp file.
>> +G1RootProcessor::~G1RootProcessor() {}
> 
> Removed.
> 
>>
>> ---
>> This doesn't seem to be used:
>>   +
>>   + template <typename Closure>
>>   + static void strong_oops_do(Closure* cl); };
> 
> The method is still used by Parallel and Serial GC.

Stefan made me aware that I looked at the wrong strong_oops_do(). 
Removed the new one, and regenerated the webrev.

Thanks,
   Thomas


More information about the hotspot-gc-dev mailing list