[15, testbug]: 8248306: gc/stress/gclocker/TestExcessGCLockerCollections.java does not compile

Thomas Schatzl thomas.schatzl at oracle.com
Fri Jun 26 09:46:45 UTC 2020


Hi Kim,

On 26.06.20 11:44, Kim Barrett wrote:
>> On Jun 25, 2020, at 5:40 AM, Thomas Schatzl <thomas.schatzl at oracle.com> wrote:
>>
>> Hi all,
>>
>>   can I have reviews for this testbug?
>>
>> Since JDK-8244010: Simplify usages of ProcessTools.createJavaProcessBuilder in our tests the gc/stress/gclocker/TestExcessGCLockerCollections.java test does not compile any more because its use of ProcessTools.createJavaProcessBuilder has not been updated.
>>
>> I simply replaced the ProcessTools.createJavaProcessBuilder() call by ProcessTools.executeTestJvm which according to the discussion for 8244010 does the right thing.
>>
>> I would like to fix this in 15, because 8244010 is in 15.
>>
>> CR:
>> https://bugs.openjdk.java.net/browse/JDK-8248306
>> Webrev:
>> http://cr.openjdk.java.net/~tschatzl/8248306/webrev/
>> Testing:
>> local run of the test
>>
>> Thanks,
>>   Thomas
> 
> Looks good.
> 

   thanks for your review.

Thomas


More information about the hotspot-gc-dev mailing list