RFR (M): 8247819: G1: Process strong OopStorage entries in parallel

Thomas Schatzl thomas.schatzl at oracle.com
Fri Jun 26 11:31:04 UTC 2020


Hi Kim,

On 25.06.20 20:38, Kim Barrett wrote:
>> On Jun 25, 2020, at 7:53 AM, Thomas Schatzl <thomas.schatzl at oracle.com> wrote:
>>
>> Hi Stefan,
>>
>>   thanks for your review.
>>
>> On 25.06.20 13:28, Stefan Karlsson wrote:
[...]
> 
> Looks good.
> 
> One minor thing, for which I don’t need a new webrev if you take this suggestion:
> 
> ------------------------------------------------------------------------------
> src/hotspot/share/gc/g1/g1GCPhaseTimes.cpp
>    69   int counter = 0;
>    70   for (OopStorageSet::Iterator it = OopStorageSet::strong_iterator(); !it.is_end(); ++it, ++counter) {
> ...
>    75     uint index = G1GCPhaseTimes::StrongOopStorageSetRoots + counter;
> 
> Rather than separate counter and index, maybe
> 
>    uint index = G1GCPhaseTimes::StrongOopStorageSetRoots;
>    for (... ++index) {
> 
> ------------------------------------------------------------------------------
> 

   will do that, thanks. For reference, here is the latest webrev:

http://cr.openjdk.java.net/~tschatzl/8247819/webrev.1_to_2/ (diff)
http://cr.openjdk.java.net/~tschatzl/8247819/webrev.2/ (full)

Thanks,
   Thomas


More information about the hotspot-gc-dev mailing list